Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer duplicate user settings files, reference files by permanent ids #78

Open
falexwolf opened this issue Oct 20, 2022 · 0 comments

Comments

@falexwolf
Copy link
Member

The only reason for duplicating user settings files across email and handle was to be able to look for them on disk.

Instead of duplicating them, to look for a matching handle etc., one could just as well parse the content of the .env files and look for the matching handle there.

Hence, I'd suggest to refactor that part of the code and only maintain exactly one kind of .env file per instance and user with the following naming convention.

user-{user_id}.env
instance-{instance_id}.env

This way, changes to user handles or instance names or user email addresses or other movable parts won't affect these .env files as the ids are permanent.

@fredericenard, would you agree that the current code design should be improved for a professional product?

Would you agree on the proposed implementation and be able to do the refactor?

Happy to call later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant