feat: support auth from docker config #2560
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Generic High Entropy Secret | 961d487 | container-engine-lib/lib/backend_impls/docker/docker_manager/docker_auth_test.go | View secret |
| - | - | Generic High Entropy Secret | 41451af | container-engine-lib/lib/backend_impls/docker/docker_manager/docker_auth_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
False positive, it's just |
|
As @pk910 mentioned it to me, this will probably not work since the engine is running in its own container, so there's no access to the users config file there. So we might need to:
|
| ) | ||
|
|
||
| // WriteStaticConfig writes a static Docker config.json file to a temporary directory | ||
| func WriteStaticConfig(t *testing.T, configContent string) string { |
There was a problem hiding this comment.
can we make make this a private helper function if it's not used outside of the package?
| return tmpDir | ||
| } | ||
|
|
||
| func TestGetAuthConfigForRepoPlain(t *testing.T) { |
Description
Supports docker credentials from config (
~/.docker/config.json). Read #2503Is this change user facing?
yes
References (if applicable)
Fixes #2503