Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect .gitignore when uploading build context #2262

Open
lostbean opened this issue Mar 6, 2024 · 2 comments
Open

Respect .gitignore when uploading build context #2262

lostbean opened this issue Mar 6, 2024 · 2 comments

Comments

@lostbean
Copy link
Contributor

lostbean commented Mar 6, 2024

Background & motivation

When using one of the features that builds images (e.g. ImageBuildSpec or NixBuildSpec) fails right now if you have large volume of data in the repo even if they are ignore data like local building and data caches.

Desired behaviour

I would to have the option (bonus if that is the default) to use gitignore to filter out what is upload to the Kurtosis building engine.

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

What area of the product does this pertain to?

CLI: the Command Line Interface

@mieubrisse
Copy link
Contributor

Hey @lostbean , agree that we need a way to filter out this data! I'm not sure .gitignore is the right way to do this though, as Git is a separate system from Nix and Docker. E.g. Docker has its own .dockerignore, separate from .gitignore and I'd guess Nix has its own. Can we use those instead?

@lostbean
Copy link
Contributor Author

lostbean commented Mar 6, 2024

Fair point, docker building could rely on things excluded by .gitignore. Nix doesn't have any special ignore system, most of the time it uses .gitignore for it. So a possible solution would be to ImageBuildSpec filter out based on . dockerignore and NixBuildSpec filter out based on . gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants