Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Allow me to not wait for pod termination in k8s #2140

Closed
barnabasbusa opened this issue Feb 9, 2024 · 3 comments
Closed

FR: Allow me to not wait for pod termination in k8s #2140

barnabasbusa opened this issue Feb 9, 2024 · 3 comments
Assignees
Labels
cli For bugs relating to the CLI feature request painful Painful bug

Comments

@barnabasbusa
Copy link
Collaborator

Background & motivation

For each task, a new pod is spun up. When this tasks completes (within a couple of seconds), the pod needs to wait for termination, which can take up to 30 seconds.

While I understand that this feature is there to ensure that each run will stay deterministic, I'd prefer if there would be a way I could pass an extra flag during runtime where I can specify not to wait for termination.

Note: This is only relevant with k8s backend.

Desired behaviour

kurtosis run . --fast-mode... would enable pods to be created, and proceed to the next plan item before waiting for pod termination.

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

What area of the product does this pertain to?

CLI: the Command Line Interface

@github-actions github-actions bot added cli For bugs relating to the CLI painful Painful bug labels Feb 9, 2024
@galenmarchetti
Copy link
Contributor

thanks for submitting a suggestion for design here, as well - i like it. ensures deterministic runs at the level of package definition while giving the end user a way to break the assumptions for a faster run, understanding you might get breakage running it 👍 checking how hard this would be

@galenmarchetti galenmarchetti self-assigned this Feb 12, 2024
@tedim52
Copy link
Contributor

tedim52 commented Feb 14, 2024

Hey @barnabasbusa here's a PR for that: #2153

github-merge-queue bot pushed a commit that referenced this issue Feb 15, 2024
## Description:
Adds a flag `--non-blocking-tasks`. If set, task services from `run_sh`
and `run_python` are not removed before continuing with execution. The
effects is small over Docker, but this significantly reduces run times
over k8s because of the overhead of removing a pod (up to 30s).

For the `ethereum-package` over k8s with images cached, running with the
flag goes from 4min to 1min. However, task services will have to be
removed manually after execution or via a `kurtosis clean`.

## Is this change user facing?
YES

## References:
#2140
@h4ck3rk3y
Copy link
Contributor

Closed by @tedim52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli For bugs relating to the CLI feature request painful Painful bug
Projects
None yet
Development

No branches or pull requests

4 participants