Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xds): ordered ADS #11579

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

check ci

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@jakubdyszkiewicz jakubdyszkiewicz added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 26, 2024
@jakubdyszkiewicz
Copy link
Contributor Author

on universal suite

2024-09-26T13:16:04.464Z	INFO	xds.dp-lifecycle	waiting for deregister proxy	{"proxyType": "dataplane", "proxyKey": {"Mesh":"dp-auth","Name":"dp-01"}, "streamID": 108, "waitFor": "0s"}
2024-09-26T13:16:04.464Z	INFO	xds.dp-lifecycle	deregister proxy	{"proxyType": "dataplane", "proxyKey": {"Mesh":"dp-auth","Name":"dp-01"}, "streamID": 108}
2024-09-26T13:16:04.475Z	INFO	xds.reconcile	config has changed	{"proxyName": "egress", "mesh": "", "versions": ["78e4d42f-5c92-426e-8b37-2302991502a0", "5cdbd604-2150-4c9f-a582-0d7ec8683129"]}
2024-09-26T13:16:04.591Z	INFO	xds.status-tracker	proxy disconnected	{"streamID": 111, "proxyName": "", "mesh": "", "subscriptionID": "bdc84fa3-ffc6-4411-9f95-f62c47e37165"}
panic: send on closed channel

goroutine 10572 [running]:
github.com/envoyproxy/go-control-plane/pkg/server/sotw/v3.(*server).process.func1()
	github.com/envoyproxy/[email protected]/pkg/server/sotw/v3/xds.go:100 +0x1b
created by github.com/envoyproxy/go-control-plane/pkg/server/sotw/v3.(*server).process in goroutine 10568
	github.com/envoyproxy/[email protected]/pkg/server/sotw/v3/xds.go:99 +0xaff

stderr:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant