Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): skip cis docker scan #11543

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

We hit rate limiting a lot in Kong Mesh.
Temporarily skip docker scan until sec team figure out trivy image cache / registry

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Sep 24, 2024
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner September 24, 2024 14:59
@jakubdyszkiewicz jakubdyszkiewicz requested review from jijiechen and Icarus9913 and removed request for a team September 24, 2024 14:59
@jijiechen jijiechen changed the title chore(ci): skip cis docker scan ci(workflow): skip cis docker scan Sep 24, 2024
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) September 24, 2024 15:15
@jakubdyszkiewicz jakubdyszkiewicz merged commit d61af00 into master Sep 24, 2024
13 of 14 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the ci/skip-docker-scan branch September 24, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants