Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kumactl): don't export full Mesh before secrets on Kubernetes #11532

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 24, 2024

Instead only export the "empty" Mesh first on Universal.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Federation e2e test flake #11420
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: skip

@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 24, 2024
Instead only export the "empty" Mesh first on Universal

Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 24, 2024 10:02
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 24, 2024 10:02
@michaelbeaumont michaelbeaumont requested review from jijiechen and jakubdyszkiewicz and removed request for a team September 24, 2024 10:02
@michaelbeaumont michaelbeaumont merged commit f249c28 into kumahq:master Sep 24, 2024
35 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/no-mesh-first-k8s branch September 24, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants