Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kumactl): declare meshes before secrets when exporting #11511

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 23, 2024

This fixes changes introduced by #11497. Universal checks whether a mesh exists before allowing a secret to be created.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Federation e2e test flake #11420
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: skip

This exports bare meshes as the very first object.

Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 23, 2024
@michaelbeaumont michaelbeaumont changed the title fix(kumactl): create meshes before secrets fix(kumactl): declare meshes before secrets when exporting Sep 23, 2024
@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 23, 2024 08:19
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 23, 2024 08:19
@michaelbeaumont michaelbeaumont requested review from jijiechen and lukidzi and removed request for a team September 23, 2024 08:19
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) September 23, 2024 08:20
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) September 23, 2024 08:22
@michaelbeaumont michaelbeaumont merged commit 77a95fa into kumahq:master Sep 23, 2024
40 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/uni-fed-mesh-ordering branch September 23, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants