Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): also apply Kuma deploy envs with Helm #11503

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

michaelbeaumont
Copy link
Contributor

This is probably the expected behavior.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something will break though...

@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 20, 2024 13:57
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 20, 2024 13:57
@michaelbeaumont michaelbeaumont requested review from Automaat and Icarus9913 and removed request for a team September 20, 2024 13:57
@michaelbeaumont michaelbeaumont merged commit 7118669 into kumahq:master Sep 20, 2024
15 checks passed
@michaelbeaumont michaelbeaumont deleted the test/e2e-fix-k8s-env branch September 20, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants