Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): set skipCreatingInitialPolicies on exported Meshes #11501

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 20, 2024

This way users have the opportunity to manage all policies themselves at the global level.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: fix(federation): set skipCreatingInitialPolicies on exported Meshes
This way users have the opportunity to manage all policies themselves at the global level.

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 20, 2024 11:42
@michaelbeaumont michaelbeaumont requested review from jijiechen and Automaat and removed request for a team September 20, 2024 11:42
@jakubdyszkiewicz
Copy link
Contributor

We need a description why we make this change

@michaelbeaumont michaelbeaumont merged commit d96cb8c into kumahq:master Sep 20, 2024
16 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/fed-skip-mesh-policy branch September 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants