Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): use helm --wait in federation tests #11408

Closed
wants to merge 7 commits into from
Closed

test(e2e): use helm --wait in federation tests #11408

wants to merge 7 commits into from

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 13, 2024 •
edited by slonka
Loading

xrel #11420

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 13, 2024
@slonka
Copy link
Contributor

slonka commented Sep 16, 2024

just FYI another federation flake: https://github.com/kumahq/kuma/actions/runs/10849140701/job/30108397949#step:12:2973

@michaelbeaumont michaelbeaumont force-pushed the test/e2e-debug-federation-failures branch 3 times, most recently from 68f4e8d to 5ef073e Compare September 16, 2024 14:45
@michaelbeaumont michaelbeaumont changed the title test(e2e): debug federation failures test(e2e): use helm --wait in federation tests Sep 16, 2024
@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 16, 2024 17:53
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 16, 2024 17:53
@michaelbeaumont michaelbeaumont requested review from jijiechen and Automaat and removed request for a team September 16, 2024 17:53
@michaelbeaumont michaelbeaumont marked this pull request as draft September 17, 2024 07:51
@michaelbeaumont
test: skip defaults
c6c98ff 
Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont
test: focus federation
f9498ba 
Signed-off-by: Mike Beaumont <[email protected]>
@lahabana
Copy link
Contributor

@michaelbeaumont should we just close this now?

@michaelbeaumont michaelbeaumont deleted the test/e2e-debug-federation-failures branch September 26, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbeaumont @slonka @lahabana @lukidzi