Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream into bevy #2

Open
JMS55 opened this issue Mar 15, 2023 · 3 comments
Open

Upstream into bevy #2

JMS55 opened this issue Mar 15, 2023 · 3 comments

Comments

@JMS55
Copy link

JMS55 commented Mar 15, 2023

I (and other bevy developers) would love to have this functionality in bevy itself. If you're up to it, please do open a PR!

@kulkalkul
Copy link
Owner

Thanks! I'd love to open a PR, though I wonder if there are issues with my implementation (one thing I need clarification on is the text cache I'm using). I suppose the only way to find out is by opening a PR 😅. I'll have to read contribution guidelines and come up with a version that's compatible with bevy. Depending on my availability, I could do that at the end of this month or next month.

@JMS55
Copy link
Author

JMS55 commented Mar 16, 2023

No rush! Feel free to open a draft PR and ask for help, that's what the PR process is for :)

@kulkalkul
Copy link
Owner

Update on this 🎉
We talked in Discord and thought it would be cool to make required changes and upstream this for bevy 0.13. Towards end of the month, I'll finish my work with #8, merge it, and upgrade it to 0.12. Then I'll work on a PR to upstream this. Related thread: https://discord.com/channels/691052431525675048/1170975253967671418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants