Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network topology information to nodes #998

Open
suket22 opened this issue Jul 19, 2024 · 1 comment · May be fixed by #1025
Open

Add network topology information to nodes #998

suket22 opened this issue Jul 19, 2024 · 1 comment · May be fixed by #1025
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@suket22
Copy link

suket22 commented Jul 19, 2024

What would you like to be added:

I'd like information about the network topology of an instance to be added to the node. This information can be dynamically retrieved via the EC2 DescribeInstanceTopology API and be applied onto the node object similar to topology.k8s.aws/zone-id, whose mechanism was introduced in this PR.

Why is this needed:
Information about an instance's topology is greatly beneficial when scheduling AI/ML workloads, where pods need to be in close proximity of one another.

Mapping the EC2 InstanceTopology to K8s labels might not be straightforward given it returns a list of network nodes, each sorted by the number of layers. We could probably choose something like -

topology.k8s.aws/network-node-1: nn1
topology.k8s.aws/network-node-2: nn2
topology.k8s.aws/network-node-3: nn3

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 19, 2024
@cartermckinnon
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 15, 2024
@wwvela wwvela linked a pull request Sep 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants