-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for IPv6/dualstack #638
Comments
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
AWS CCM has been patching in both IPv6 and IPv4 IPs for quite some time. You just have to set See https://github.com/kubernetes/cloud-provider-aws/blob/master/pkg/providers/v1/aws.go#L1599 |
This comment was marked as outdated.
This comment was marked as outdated.
As found in #677 I'm using v1 after all. I gave this another attempt, setting the feature gate
I realised that [Global]
NodeIPFamilies=ipv4,ipv6 Which I can verify works via the log line:
The controller is now failing with e.g.:
I'm not sure why it's failing to get the node address, see {
"PrivateIpAddress": "10.24.152.220",
"Ipv6Address": "2600:1f10:45a5:a918:fd18:12af:1613:6c5d",
"NetworkInterfaces": [
{
"Association": {
"IpOwnerId": "amazon",
"PublicDnsName": "ec2-3-85-73-150.compute-1.amazonaws.com",
"PublicIp": "3.85.73.150"
},
"Attachment": {
"AttachTime": "2023-10-17T03:03:45+00:00",
"AttachmentId": "eni-attach-024b4933411c5f575",
"DeleteOnTermination": true,
"DeviceIndex": 0,
"Status": "attached",
"NetworkCardIndex": 0
},
"Description": "",
"Groups": [
{
"GroupName": "internal-talos-worker-general",
"GroupId": "sg-007b939554373cc2b"
}
],
"Ipv6Addresses": [
{
"Ipv6Address": "2600:1f10:45a5:a918:fd18:12af:1613:6c5d",
"IsPrimaryIpv6": false
}
],
"MacAddress": "0e:41:8b:af:7f:5f",
"NetworkInterfaceId": "eni-0aabf40c0e2dcd595",
"OwnerId": "799078726966",
"PrivateDnsName": "i-083e6ed22b10ddf06.ec2.internal",
"PrivateIpAddress": "10.24.152.220",
"PrivateIpAddresses": [
{
"Association": {
"IpOwnerId": "amazon",
"PublicDnsName": "ec2-3-85-73-150.compute-1.amazonaws.com",
"PublicIp": "3.85.73.150"
},
"Primary": true,
"PrivateDnsName": "i-083e6ed22b10ddf06.ec2.internal",
"PrivateIpAddress": "10.24.152.220"
}
],
"SourceDestCheck": true,
"Status": "in-use",
"SubnetId": "subnet-00c5e1b9c4baddcb3",
"VpcId": "vpc-060c91b3879fc8b83",
"InterfaceType": "interface"
}
]
} |
From poking around the code and seeing your info above, it's not apparent to me what went wrong yet. Would it be convenient to add additional logging? Would be curious what addresses get returned by the cloud provider given that the IP it's looking for is very apparent. |
Not really for our configuration; would have to set up a whole custom build pipeline where we currently use the upstream image.
Yeah that's probably a good debug log to add. |
A repro would make it a lot easier to debug. Perhaps it could be setup via another mechanism, if it's an issue with the cloud provider.
Ya. There's not a lot of logging in the cloud provider, though some of this could make sense to add in kubernetes/kubernetes, and seems very reasonable to add some debug level logging for exactly this kind of thing. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale I would love it if someone could just add some more debug logging around this in the cloud provider. |
We face the same issue.
But I saw both the IPv6 and the IPv4 address in the InternalIP. |
I think I found what caused this.
It generated this log line:
So the configuration is parsed as a string
I recommend to include this in the documentation. It was a bit frustrating that I had to read the code as I did not find any documentation about how to construct the cloud-config file (I even started with a YAML first). |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What would you like to be added:
I'd like to start using dualstack in our kubernetes cluster via the
CloudDualStackNodeIPs
feature gate.Trying to do so I get errors such as:
Trying to debug the issue, I think it's because the code at
https://github.com/kubernetes/cloud-provider-aws/blob/d0551093673e8c355db17249b8f069767c014748/pkg/providers/v2/instances.go#L216C46-L216C64 doesn't look at
Ipv6Addresses
. It only iterates over the IPv4 addresses inPrivateIpAddresses
.Why is this needed:
The EC2 api returns IPv6 and IPv4 addresses in different fields.
/kind feature
The text was updated successfully, but these errors were encountered: