Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to make use of least-nodes expander in the autoscaler #7200

Open
Kaikj opened this issue Aug 22, 2024 · 2 comments
Open

Unable to make use of least-nodes expander in the autoscaler #7200

Kaikj opened this issue Aug 22, 2024 · 2 comments
Labels
area/cluster-autoscaler kind/bug Categorizes issue or PR as related to a bug.

Comments

@Kaikj
Copy link

Kaikj commented Aug 22, 2024

Which component are you using?: Cluster Autoscaler

What version of the component are you using?: The bug exists in the master branch

Component version:

What k8s version are you using (kubectl version)?: The version of kubectl does not matter

kubectl version Output
$ kubectl version

What environment is this in?:
This affects all environments as the bug is in the code

What did you expect to happen?:
The least-nodes expander to be selected after choosing it

What happened instead?:
The least-nodes expander is not part of the set of available expanders

How to reproduce it (as minimally and precisely as possible):
Simply try to make use of least-nodes expander.

The least nodes expander introduced in #6792 did not add the expander into the list of Available Expanders. The easy fix would be to simply add it in but I cannot be sure if it is intended to be left out for now or if it has just been missed out.

Happy to open a PR for this if it helps. The bug occurs in https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/expander/expander.go

Anything else we need to know?:

@Kaikj Kaikj added the kind/bug Categorizes issue or PR as related to a bug. label Aug 22, 2024
@adrianmoisey
Copy link
Member

/area cluster-autoscaler

@areeba-anwar
Copy link

Environment: This issue affects all environments since the bug exists within the code itself.

Expected Behavior: After selecting the least-nodes expander, it should be available as an option.

Actual Behavior: The least-nodes expander is missing from the list of available expanders.

Steps to Reproduce:

Attempt to use the least-nodes expander.
Observe that it does not appear in the set of available expanders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants