Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ConfigTree in approve plugin #147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement ConfigTree in approve plugin #147

wants to merge 1 commit into from

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented May 13, 2024 •
edited
Loading

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@netlify Netlify
Copy link

netlify bot commented May 13, 2024 •
edited
Loading

✅ Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 748c701
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6641b1a141fbc8000870274d
😎 Deploy Preview https://deploy-preview-147--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 13, 2024
@matthyx
Copy link
Contributor Author

matthyx commented May 13, 2024

/test all

@matthyx matthyx mentioned this pull request May 13, 2024
Closed
@matthyx
Copy link
Contributor Author

matthyx commented May 13, 2024

/retest

@matthyx matthyx marked this pull request as ready for review May 13, 2024 10:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@matthyx matthyx mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner Awaiting requested review from cjwagner

@petr-muller petr-muller Awaiting requested review from petr-muller

@droslean droslean Awaiting requested review from droslean

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prow config: where possible, all config should behave like branchprotector for overrides
2 participants
@matthyx @k8s-ci-robot