Bugfix Mikrotik version > 6.48 = 'export' command incomplete #3405 #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompt regex for MikroTik generates so it matches only if prompt string is found in the end of string (no more printable symbols were printed after it).
…/Tonygratta/netmiko into bugfix#3405-mikrotik-promptsring
|
Does just switching to dumb terminal setting make this change unnecessary? See: |
|
Tried that, but unfortunately it doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix generates a regex string for search pattern using in send_command function for MikroTik devices. This regex expression searches not just the prompt string, but the prompt string exactly at the end of the output string, without any symbols after it. It prevents premature termination of the collecting data process.
Checked on hardware: