Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruckus_fastiron.py KexAlgorithms & HostKeyAlgorithms #3449

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

EdificomSA
Copy link

Add _modify_connection to add DH group 14 & g1 KexAlgorithms and ssh-rsa HostKeyAlgorithms

EdificomSA and others added 2 commits July 2, 2024 10:46
_modify_connection to add DH group 14 & g1 KexAlgorithms and ssh-rsa HostKeyAlgorithms
paramiko.Transport._preferred_keys.add(
"ssh-rsa",
)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you retrieve paramiko_transport, but then change and reference paramiko.Transport?

Shouldn't it be:

        paramiko_transport = getattr(paramiko, "Transport")
        paramiko_transport._preferred_kex.add(
            "diffie-hellman-group14-sha1",
            "diffie-hellman-group1-sha1",
        )
        paramiko_transport._preferred_keys.add(
            "ssh-rsa",
        )

@ktbyers
Copy link
Owner

ktbyers commented Jul 10, 2024

These all look like they are already there by default? Why do we need this change?

>>> paramiko.Transport._preferred_kex
('[email protected]', 'ecdh-sha2-nistp256', 'ecdh-sha2-nistp384', 'ecdh-sha2-nistp521', 'diffie-hellman-group16-sha512', 'diffie-hellman-group-exchange-sha256', 'diffie-hellman-group14-sha256', 'diffie-hellman-group-exchange-sha1', 'diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1')
>>> paramiko.Transport._preferred_keys
('ssh-ed25519', 'ecdsa-sha2-nistp256', 'ecdsa-sha2-nistp384', 'ecdsa-sha2-nistp521', 'rsa-sha2-512', 'rsa-sha2-256', 'ssh-rsa', 'ssh-dss')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants