introduces raise_on_parsing_error parameter to send_command
#3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kircheneer
force-pushed
the
raise-on-parsing-error
branch
2 times, most recently
from
dca07d1
to
206e4d2
Compare
|
As discussed on Slack I have renamed the parameter and added an initial set of tests. |
|
Please approve CI workflow whenever possible. Thanks! |
Kircheneer
force-pushed
the
raise-on-parsing-error
branch
from
206e4d2
to
5cc107f
Compare
Kircheneer
force-pushed
the
raise-on-parsing-error
branch
from
5cc107f
to
5270c3d
Compare
Allow exceptions from structured data parsers to bubble up to the callers of `send_command` and `send_command_timing`. This is useful for example in conjunction with `nornir_netmiko`, which currently can't fail tasks based on failed parsing, leading to successful tasks with garbage data.
Kircheneer
force-pushed
the
raise-on-parsing-error
branch
from
5270c3d
to
04f2530
Compare
|
Looks to fix #3479 |
|
Superseded by #3494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow exceptions from structured data parsers to bubble up to the callers of
send_commandandsend_command_timing. This is useful for example in conjunction withnornir_netmiko, which currently can't fail tasks based on failed parsing, leading to successful tasks with garbage data.