Update f5_tmsh_ssh.py fixed "quit" #3403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed "quit" closing session command, nothing is expected since the session is terminated immediately.
ktbyers
reviewed
Mar 15, 2024
| @@ -22,7 +22,7 @@ def tmsh_mode(self, delay_factor: float = 1.0) -> str: | |||
| return output | |||
|
|
|||
| def exit_tmsh(self) -> str: | |||
| output = self._send_command_str("quit", expect_string=r"#") | |||
| output = self._send_command_str("quit", expect_string=r"") | |||
There was a problem hiding this comment.
A null expect string is not valid/correct (i.e. should do a write_channel() instead)
Also it looks like whether quit causes the SSH to terminate depends:
You can exit tmsh by entering quit. Two different results may occur, depending on the
user's terminal access type:
If you are granted bash access, you will be returned to bash.
If you are granted tmsh access, you will be logged out of the BIG-IP system.
So we would probably need to handle both cases (likely via a try/except block).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed "quit" closing session command, nothing is expected since the session is terminated immediately.