added oneaccess_tdre #3360
Open
added oneaccess_tdre #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Using netmiko version 4.1.2 I have used the device type "oneaccess_oneos" when logging into OneAccess hardware models 1424, 1623, 1645 & 1646.
I recently noticed however that these hardware models are running the OS "TDRE", not "OneOS".
In version 4.2.0 the "oneaccess_oneos" code is different from 4.1.2 and so if i use "oneaccess_oneos" in 4.2.0 I get "Pattern not detected: '(\#|>)' in output." when logging into OneAccess devices with TDRE.
I think it would be logical to create a separate device type for "oneaccess_tdre" that has pretty much the same code as in 4.1.2, but removing the commands from set_terminal_width and disable_paging as they do not work for TDRE. I also think it should use BaseConnection instead of CiscoBaseConnection as it doesn't have enable or config modes like Cisco.
Br,
Alex