Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vyos_ssh.py #3296

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Update vyos_ssh.py #3296

merged 5 commits into from
Oct 17, 2023

Conversation

ovikosta
Copy link
Contributor

Raise ValueError without call config_mode

Raise ValueError without call config_mode
@ktbyers
Copy link
Owner

ktbyers commented Sep 21, 2023

Probably should exit_config_mode() also (if we are going to enter config mode).

Also you need output += on the second output capture (or it will overwrite the first output).

@ovikosta
Copy link
Contributor Author

No problem and also add exit_config_mode() in function def commit()?

        output = self.config_mode()
        output += self._send_command_str(
            command_string,
            strip_prompt=False,
            strip_command=False,
            read_timeout=read_timeout,
        )

@ktbyers ktbyers merged commit e2135e7 into ktbyers:develop Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants