Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] LS not responding properly when POM file is malformed #507

Closed
1 task done
jmle opened this issue Feb 16, 2024 · 4 comments
Closed
1 task done

[BUG] LS not responding properly when POM file is malformed #507

jmle opened this issue Feb 16, 2024 · 4 comments
Assignees
@shawn-hurley
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. provider/java triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.1

Comments

@jmle
Copy link
Contributor

jmle commented Feb 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3.0

Priority

Critical

Current Behavior

If the pom file of the project to be analyzed is broken in any way:

  • Malformed (for instance, missing the groupId
  • Artifacts that cannot be found
  • Etc...

then the java provider won't give references back at all.

Expected Behavior

If the pom file is malformed, we should at least return an error message specifying the problem

How Reproducible

Always (Default)

Steps To Reproduce

Try to analyze any application with a broken POM and see how no results are returned.

Environment

No response

Anything else?

No response
@jmle jmle added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 16, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Feb 16, 2024
@pranavgaikwad
Copy link
Contributor

/priority backlog
/triage accepted

@pranavgaikwad pranavgaikwad added this to the v0.4.0 milestone Mar 4, 2024
@konveyor-ci-bot konveyor-ci-bot bot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 4, 2024
@pranavgaikwad pranavgaikwad added provider/java and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 4, 2024
@shawn-hurley shawn-hurley self-assigned this Mar 25, 2024
@pranavgaikwad pranavgaikwad modified the milestones: v0.4.0, v0.5.0 Apr 23, 2024
@shawn-hurley
Copy link
Contributor

This will be fixed with

konveyor/tackle2-addon-analyzer#97
konveyor/tackle2-addon-analyzer#101

@dymurray dymurray modified the milestones: v0.5.0, v0.5.1 Aug 1, 2024
@shawn-hurley
Copy link
Contributor

PR's are merged closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawn-hurley shawn-hurley

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. provider/java triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.1
Development

No branches or pull requests
4 participants
@shawn-hurley @jmle @pranavgaikwad @dymurray