Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mac OS arm64 build support #65

Closed
KaymeKaydex opened this issue Jan 31, 2023 · 7 comments
Closed

Add Mac OS arm64 build support #65

KaymeKaydex opened this issue Jan 31, 2023 · 7 comments

Comments

@KaymeKaydex
Copy link

always we do cp /opt/pdfium/lib/libpdfium.so /usr/lib/libpdfium.so

but on Mac OS instead of the .so file, libpdfium.dylib is located

@jerbob92
Copy link
Contributor

jerbob92 commented Jan 31, 2023

I don't think I need to do anything to make Mac OS work right? The build tests already include Mac OS. On Mac OS you need to set the env variable env DYLD_LIBRARY_PATH=/opt/pdfium/lib
Where /opt/pdfium is where you extracted a release from https://github.com/bblanchon/pdfium-binaries/releases (either ios-arm64 or ios-x64)

@KaymeKaydex
Copy link
Author

May be we need to add it to documentation?

@jerbob92
Copy link
Contributor

I'm not completely sure if you actually need it. Might be enough to have the pkg-config.
Will check soon.

@gedw99
Copy link

gedw99 commented Jan 31, 2023

Any chance we can have a simple makefile that does the repetitive stuff ?

like pull releases from https://github.com/bblanchon/pdfium-binaries/releases

and build etc

@jerbob92
Copy link
Contributor

jerbob92 commented Jan 31, 2023

Yeah sounds good to me :) I'm not really efficient in Makefiles, but sounds like a good addition to make installs easier, so will accept PR's.

Actually, won't it be better to add that to pdfium-binaries? Then everyone can benefit from it that uses the binaries.

@KaymeKaydex
Copy link
Author

Yeah sounds good to me :) I'm not really efficient in Makefiles, but sounds like a good addition to make installs easier, so will accept PR's.

Actually, won't it be better to add that to pdfium-binaries? Then everyone can benefit from it that uses the binaries.

Yes, it would be cool to make a make command that would download the latest version of the compiled library

@jerbob92
Copy link
Contributor

I will close this issue for now. I don't think this project should deal with binary distributions of pdfium (except for the Webassembly version). It would be nice if https://github.com/bblanchon/pdfium-binaries could also automatically be pushed to a PPA for Ubuntu/Debian and perhaps to Homebrew for MacOS? I have opened an issue for that on there: bblanchon/pdfium-binaries#114

@jerbob92 jerbob92 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants