Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing should not fail for a single parsing error #19

Open
Toilal opened this issue Jan 17, 2015 · 6 comments
Open

Processing should not fail for a single parsing error #19

Toilal opened this issue Jan 17, 2015 · 6 comments

Comments

@Toilal
Copy link

Toilal commented Jan 17, 2015

https://github.com/klei/gulp-angular-filesort/blob/master/index.js#L24

Does this make sense to through this error instead of continuing ? If there is about 100 javascript files to sort, why breaking the whole processing just because of one file ?

@zckrs
Copy link

zckrs commented Mar 2, 2015

@joakimbeng do you have a opinion on that ? 😃

@joakimbeng
Copy link
Member

Sorry for my slow response :P

I think you're right. Do you think it should log anything when a syntax error is found, or be totally quiet?

@zckrs
Copy link

zckrs commented Mar 3, 2015

In my opinion a gulp plugin shloud parse argv to catch the --verbose option of cli cmd gulp.
Like https://github.com/zckrs/gulp-css-base64/blob/master/src/index.js#L31
See comment

@Toilal
Copy link
Author

Toilal commented Mar 3, 2015

I'm not sure it should depend on --verbose flag because it's an error. It should be logged maybe at warning level.

@ricolo
Copy link

ricolo commented Apr 17, 2015

Here's the handling of the same issue in gulp-sass by passing in an option {errLogToConsole: true}:
http://blog.ionic.io/fixing-a-broken-sass-build-stream/

@pedroassis
Copy link

Came across a issue where if you try to sort a stream of files where you have both your js and css the lib will fail silently.

Example:
gulp.src(['./src/**/*.js', './src/**/*.css'], {read: false});

I don't think it should even fail, don't parse non js files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants