Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surfer doesn't build anymore #243

Closed
rgaudin opened this issue Jul 21, 2023 · 3 comments
Closed

Surfer doesn't build anymore #243

rgaudin opened this issue Jul 21, 2023 · 3 comments
Assignees
Labels

Comments

@rgaudin
Copy link
Member

rgaudin commented Jul 21, 2023

See https://github.com/kiwix/container-images/actions/runs/5621647983/job/15232827787

Haven't checked but probably a dependency issue. We're just doing an npm install AFAIK

@rgaudin rgaudin added the bug label Jul 21, 2023
@benoit74 benoit74 self-assigned this Jul 27, 2023
@benoit74
Copy link
Collaborator

benoit74 commented Jul 27, 2023

I had a look into this issue.

The fact that the build failed is linked to some files which are not present anymore in the release .tar.gz archive we download.

The underlying root problem is that Surfer has changed quite significantly and broke a significant part of our custom image.

From the changelog:

[5.18.0]
* Move to vitejs as the buildtool
* Use nodejs 18.12.1

[6.0.0]
* Move from LDAP auth to Cloudron OpenID
* surfer cli now only works with API access tokens created in the admin UI
* WebDAV access requires an API access token as the password

Looks like there is no more admin CLI + there are probably other gotchas (e.g. I'm not sure that .users.json file is still in use).

Anyway, this means it is not a small issue solvable quickly, I stop to work on this for now until it gets prioritized

@benoit74 benoit74 removed their assignment Jul 27, 2023
rgaudin added a commit that referenced this issue Aug 7, 2023
@kelson42 kelson42 pinned this issue Oct 1, 2023
@kelson42
Copy link
Contributor

@rgaudin Should we close this (now that we don'use Surfer for our drives)? Maybe there is a bit of cleaning work to do here as well?

@rgaudin
Copy link
Member Author

rgaudin commented Sep 11, 2024

i want to delete it from repo first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants