Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using Forgejo as OIDC provider #401

Open
LordMZTE opened this issue Oct 29, 2023 · 2 comments
Open

Error when using Forgejo as OIDC provider #401

LordMZTE opened this issue Oct 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@LordMZTE
Copy link

When using Forgejo as an OIDC provider, Kitsune will return a HTTP 500 after confirming the login in Forgejo.

If the cache.type option is set to in-memory, this error will be in the logs:

ERROR kitsune::error: Error occurred in handler error=Core(Api(RegistrationsClosed))
ERROR tower_http::trace::on_failure: response failed classification=Status code: 500 Internal Server Error latency=105 ms

with the options set to redis, this error will be emitted instead:

2023-10-29T14:54:50.076863Z  INFO log: NOTICE: relation "__diesel_schema_migrations" already exists, skipping
2023-10-29T14:55:01.434253Z ERROR kitsune::error: Error occurred in handler error=Oidc(LoginState(SimdJson(Error { index: 0, character: None, error: Serde("UUID parsing failed: UUIDError") })))
@aumetra
Copy link
Member

aumetra commented Oct 29, 2023

The first error should be closed by #400

I'll try to reproduce and fix the second one with #399

@aumetra aumetra self-assigned this Oct 29, 2023
@aumetra aumetra added the bug Something isn't working label Oct 29, 2023
@aumetra
Copy link
Member

aumetra commented Dec 7, 2023

I have a weird sneaking suspicion here..

The main difference between redis and in-memory caching is that we are de-/serializing redis entries from/into JSON..

And this seems like a UUID parsing Error. This could potentially be an issue caused by faulty de-/serialization logic? Maybe?

I haven't tested it yet, but that's just a hunch I just had

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants