Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiteView #3

Open
xinsight opened this issue Mar 10, 2017 · 0 comments
Open

KiteView #3

xinsight opened this issue Mar 10, 2017 · 0 comments

Comments

@xinsight
Copy link

I noticed that there is a KitePresentationViewController but no access to the containing view (KiteView?). It seems simpler and more conventional to add an animation to an existing view instead of having to deal with a nested view controller. (You also don't need to bother about retaining the view controller as a local variable.)

For example, instead of:

    guard let kitePresentationViewController = KitePresentationViewController(kiteDocument: kiteDocument) else {
        fatalError("Could not create Kite Presentation View Controller")
    }
    self.kiteViewController = kitePresentationViewController
    self.placeholderView?.addSubview(kitePresentationViewController.view)

Adding a kite animation would be:

    guard let kiteView = KiteView(with: kiteDocument) else {
        fatalError("Could not create KiteView")
    }
    self.placeholderView?.addSubview(kiteView)

Is access to the kite view on the roadmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant