Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peerDependencies and shrinkwrap not fitting installed dependencies #14

Open
julrich opened this issue Sep 26, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@julrich
Copy link
Member

julrich commented Sep 26, 2023

This is a problem in jsonschema-utils, where we've added our modules as peerDependencies to ensure they are actually present, because we rely on that to load kickstartDS JSON Schemas (e.g. to layer types and schemas).

When those are added, and any other dependency changes the pnpm shrinkwrap / lockfile (e.g. because of install / uninstall), this leaves a warning for jsonschema-utils.

Only workaround currently: Remove peerDependencies, run an update (rush update), re-add peerDependencies, run an update again... which now works, and leaves the shrinkwrap / lockfile in a error- / warning-free state.

Relevant code: https://github.com/kickstartDS/schema/blob/main/tools/jsonschema-utils/package.json#L49-L55

@julrich julrich added the bug Something isn't working label Sep 26, 2023
@julrich julrich added this to the Release 09/2023 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant