From ba7cd7e7011dadbf4bba7bc901e26b74f52b0ffc Mon Sep 17 00:00:00 2001 From: Giorgi Kavrelishvili Date: Wed, 11 Oct 2023 18:18:48 +0400 Subject: [PATCH 1/2] Move to Process.on_interupt I remember this change was implemented before, I see that it is reverted now and I want that change back because developers on Windows are complaining that it broke their builds. --- src/kemal.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kemal.cr b/src/kemal.cr index 5d43f15a..cec46aeb 100644 --- a/src/kemal.cr +++ b/src/kemal.cr @@ -89,10 +89,10 @@ module Kemal end private def self.setup_trap_signal - Signal::INT.trap do + Process.on_interrupt { log "#{Kemal.config.app_name} is going to take a rest!" if Kemal.config.shutdown_message Kemal.stop exit - end + } end end From 9827dbf548d7109db74bc5eb7db79c53136d755f Mon Sep 17 00:00:00 2001 From: Giorgi Kavrelishvili Date: Tue, 2 Jan 2024 17:53:04 +0400 Subject: [PATCH 2/2] Apply suggestions from code review Proper multiline block Co-authored-by: Sijawusz Pur Rahnama --- src/kemal.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kemal.cr b/src/kemal.cr index cec46aeb..843f89e4 100644 --- a/src/kemal.cr +++ b/src/kemal.cr @@ -89,10 +89,10 @@ module Kemal end private def self.setup_trap_signal - Process.on_interrupt { + Process.on_interrupt do log "#{Kemal.config.app_name} is going to take a rest!" if Kemal.config.shutdown_message Kemal.stop exit - } + end end end