Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single Node.js version #14

Open
lukasz-zimnoch opened this issue Jul 23, 2020 · 1 comment
Open

Use single Node.js version #14

lukasz-zimnoch opened this issue Jul 23, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@lukasz-zimnoch
Copy link
Member

lukasz-zimnoch commented Jul 23, 2020

Currently install.sh script requires node 11.15.0 to be executed successfully. Using a newer version cause fails during npm install in keep-core and keep-ecdsa repositories. On the contrary, e2e tests use some features (like json-modules) which are available in node > 13 hence we have to switch node versions which is cumbersome. The need of switch also causes some non-blocking errors related to node-gyp while executing e2e tests. We should find a way to run everything using a single node version and fix the problem with node-gyp.

@Shadowfiend
Copy link
Contributor

Using a newer version cause fails during npm install in keep-core and keep-ecdsa repositories.

Can you give me a pointer on this? I've been doing npm install for keep-core and keep-ecdsa both with Node 12.16.3 for a while with no issues. The node-gyp builds fail, but do not result in an install failure (all of the relevant packages in our dependencies fall back on JS implementations of the native-built functions).

e2e tests use some features (like json-modules) which are available in node > 13

A small nit here: Node 12 (the LTS version) supports JSON modules as well as the --experimental-json-modules flag.

I can't speak to other Node versions, but I suggest it may be worth trying specifically anchoring to Node 12 for the full build. Since it's the LTS version, I think that's also a sound decision overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants