From 6cdec1400133ce573cdf445d6fe6464b5bbc2387 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pedro=20T=C3=B4rres?= Date: Tue, 27 Jun 2023 08:00:05 +0100 Subject: [PATCH] Remove ScaledObject Custom Labels (#721) Co-authored-by: Tom Kerkhove Co-authored-by: Jorge Turrado Ferrero --- CHANGELOG.md | 1 + pkg/k8s/meta.go | 10 ---------- pkg/k8s/scaledobject.go | 1 - 3 files changed, 1 insertion(+), 11 deletions(-) delete mode 100644 pkg/k8s/meta.go diff --git a/CHANGELOG.md b/CHANGELOG.md index d52bdab5..fdaec82c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ This changelog keeps track of work items that have been completed and are ready ### Fixes - **Scaler**: remplement custom interceptor metrics ([#718](https://github.com/kedacore/http-add-on/issues/718)) +- **Operator**: Remove ScaledObject `name` & `app` custom labels ([#717](https://github.com/kedacore/http-add-on/issues/717)) ### Deprecations diff --git a/pkg/k8s/meta.go b/pkg/k8s/meta.go deleted file mode 100644 index 5a14c415..00000000 --- a/pkg/k8s/meta.go +++ /dev/null @@ -1,10 +0,0 @@ -package k8s - -import "fmt" - -func Labels(name string) map[string]string { - return map[string]string{ - "name": name, - "app": fmt.Sprintf("kedahttp-%s", name), - } -} diff --git a/pkg/k8s/scaledobject.go b/pkg/k8s/scaledobject.go index 97e3d7f3..7a776d9c 100644 --- a/pkg/k8s/scaledobject.go +++ b/pkg/k8s/scaledobject.go @@ -38,7 +38,6 @@ func NewScaledObject( ObjectMeta: metav1.ObjectMeta{ Namespace: namespace, Name: name, - Labels: Labels(name), }, Spec: kedav1alpha1.ScaledObjectSpec{ ScaleTargetRef: &kedav1alpha1.ScaleTarget{