Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detailed macOS and Windows version #55

Closed
kdeldycke opened this issue Sep 5, 2024 · 1 comment
Closed

Add detailed macOS and Windows version #55

kdeldycke opened this issue Sep 5, 2024 · 1 comment
Labels
✨ enhancement Improvement or change to an existing feature

Comments

@kdeldycke
Copy link
Owner

macOS and Windows families are properly identified. Which partly solves python-distro/distro#177

Now we can refine the detection and provides a classification for each version.
@kdeldycke kdeldycke added ✨ enhancement Improvement or change to an existing feature 🙏 help wanted I can't do this alone and need contributors labels Sep 5, 2024
@kdeldycke
Copy link
Owner Author

kdeldycke commented Sep 5, 2024 •
edited
Loading

Some pointers for inspiration:
https://github.com/python-distro/distro/pull/185/files#diff-8460161e1c716ddfac36842dd521facd94d306d2964d24480c4ced4a38d1d6f6
https://github.com/python-distro/distro/pull/185/files#diff-2401bd6991bc7b9c1b38addc679bc6d7ac93be1b1caeeef53c718aecbd553b96
https://docs.python.org/3.12/library/platform.html#windows-platform
https://docs.python.org/3.12/library/platform.html#macos-platform
https://github.com/saltstack/salt/blob/246d0664577ef72da8bd1f0c4dff0d18b4428b23/salt/grains/core.py#L1432-L1488

kdeldycke added a commit that referenced this issue Sep 11, 2024
@kdeldycke
Add detection of all macOS versions
02112d0 
See:
#55
python-distro/distro#177
python-distro/distro#185
@kdeldycke kdeldycke removed the 🙏 help wanted I can't do this alone and need contributors label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement Improvement or change to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdeldycke