Make development on macs easier #3015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change goreleaser will build the `kanctl` binary that can be used on arm64 machines and it will also build the controller container image for correct platform so that it can be deployed on k8s clusters. By default, I think it was building the container image for arm64 platform.
pavannd1
reviewed
Aug 14, 2024
| build_flag_templates: | ||
| - "--pull" | ||
| - "--platform=linux/amd64" |
There was a problem hiding this comment.
Can this be made configurable for downstream builders?
There was a problem hiding this comment.
I think it can be done. I have still not figured this out. I will spend some more time and make this reviewable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
After this change goreleaser will build the
kanctlbinary that can be used on arm64 machines and it will also build the controller container image for correct platform so that it can be deployed on k8s clusters. By default, I think it was building the container image for amd64 platform.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan