Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeset support and path-style s3 endpoint #2974

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michaelcourcy
Copy link
Contributor

Change Overview

This PR introduce support for elasticsearch cluster that have more than one nodeset (it was not supported before) and set up path_style_access=true when using a non AWS S3 endpoint otherwise the url domain is built with the name of the bucket and the region and this setting is not supported most of the time for s3 compliant endpoint.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • [x ] 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • No issues has been officially opened

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

}
}
'

echo "delete the snap $SNAPSHOT_NAME"
curl -k -u "elastic:$PASSWORD" -X DELETE "${ES_URL}/_snapshot/k10_repo/$SNAPSHOT_NAME?pretty"
echo "Deletion of $SNAPSHOT_NAME was successful"

echo "Deletion of $SNAPSHOT_NAME was successful"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Deletion of $SNAPSHOT_NAME was successful"
echo "Deletion of $SNAPSHOT_NAME was successful"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

3 participants