Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of required functionality #1

Merged
merged 45 commits into from
Feb 13, 2024
Merged

Initial implementation of required functionality #1

merged 45 commits into from
Feb 13, 2024

Conversation

e-sumin
Copy link
Collaborator

@e-sumin e-sumin commented Dec 4, 2023

Implementing functionality proposed in design proposal #2

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@hairyhum hairyhum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some questions about usage and documenting less obvious behaviour.

errors.go Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@denisvmedia
Copy link

I see another draft PR merged without changing the title and putting the description. Can we please improve the title and the desc here before we merge it?

@hairyhum
Copy link

I see another draft PR merged without changing the title and putting the description. Can we please improve the title and the desc here before we merge it?

@e-sumin yes, can we get the final version in a single PR?

@e-sumin e-sumin changed the title Draft Initial implementation of required functionality Feb 6, 2024

// GetFrame returns information about a caller function at the specified depth
// above this function in the the call stack.
func GetFrame(depth int) Frame {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is only called in the test as I understand.
Is there some other use for it?
If not, should it be moved to the test or maybe test helper file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing, in last commit I've extracted part which is common for marshalling code and for tests, and removed all irrelevant things.

Please re-review this commit.

Copy link

@hairyhum hairyhum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from internal/caller/frame.go file.

@e-sumin e-sumin requested a review from hairyhum February 8, 2024 14:06
Copy link

@hairyhum hairyhum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-sumin e-sumin merged commit 541a584 into main Feb 13, 2024
4 checks passed
@e-sumin e-sumin deleted the draft branch February 13, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants