Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create flow for automating byte-buddy version bump #161

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

hughsimpson
Copy link
Contributor

@hughsimpson hughsimpson commented Sep 10, 2024

Automates bumping byte-buddy versions. Since bumps will, presumably, mostly be triggered off personal forks, it's not possible to push the bot commit directly to the branch. Additionally, without providing a personal access token, it's not possible for the github actions bot to directly trigger the test workflow. So, the flow is a little more convoluted than I'd like, but still feels more streamlined and preserves provenance. I've tested the following flow locally against my own fork:

You'll have noticed that the new workflow is failing in this pr.. That's because, by adding the byte-buddy-tag file I've triggered the constraint, but the workflow permissions (specifically pull-requests: write and contents: write) don't take effect until merged. Linked to my fork so you can see that it does, in fact, work once merged :)

cc @ivantopo @dpsoft thoughts on this? I believe it could be made more streamlined with a personal access token set by a repo owner, but since I'm not one, this is pretty much the best I think I can do...

@hughsimpson
Copy link
Contributor Author

@dpsoft any comments on this?

Copy link
Contributor

@dpsoft dpsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hughsimpson LGTM.

@hughsimpson
Copy link
Contributor Author

Thanks @dpsoft . I don't have perms, could you do the honours? I'll try out out once it's merged so you should see a follow-up with the lib bump 🤞

@dpsoft dpsoft merged commit b30542a into kamon-io:master Sep 25, 2024
4 of 5 checks passed
@dpsoft
Copy link
Contributor

dpsoft commented Sep 25, 2024

@hughsimpson done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants