You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
This is a bit of a strange issue that is hard to explain what is going on but I will try my best.
I was working on a reported issue in one of my addons, the issue was a strange behaviour in the FastBoot render hence the need for a FastBoot testing harness. I set up a test using ember-fastboot-addon-tests to attempt a "red/green" test, making sure that I could capture a failing test before getting it working again.
I managed to capture the failing scenario with a test but when I implemented the fix and tried to run ember fastboot:test it didn't actually pick up any of my changes. I then ran the dummy app with ember-cli-fastboot and it seemed to have fixed my issue when doing manual testing.
At this point I thought it was a cache issue so I cleared my dist and tmp folders and ran ember fastboot:test again and it still didn't work. Even a fresh build on Travis wasn't working correctly.
I then published the addon as a patch version because I was relatively sure the fix was valid because of my manual testing and then when running the local ember fastboot:test again it started working.
My best guess for a mental model of what is going on here is that the ember fastboot:test is somehow installing my addon from npm instead of using the local files, which would mean that it would need an npm publish before it would pick up changes that would fix any tests that are broken.
I could probably recreate this issue if you would like a demo, but I'm wondering if this is a known behaviour already before I spend the time on attempting a re-creation.
Let me know if you have any questions 👍
The text was updated successfully, but these errors were encountered:
@simonihmig as you can see by all the linked issues/PRs I have done a bit of investigation into this 😂 and yes I think that's the issue that I'm facing.
It's a long-standing issue with npm that they are in the process of fixing but we could potentially fix this if we could get the link part of the process to happen after all npm install commands are executed.
I had my best crack at it with the little amount of context I could follow in the time that I had, maybe you can see a way to navigate this? If you wanted to pair on this for a bit this week I'm free too
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a bit of a strange issue that is hard to explain what is going on but I will try my best.
I was working on a reported issue in one of my addons, the issue was a strange behaviour in the FastBoot render hence the need for a FastBoot testing harness. I set up a test using ember-fastboot-addon-tests to attempt a "red/green" test, making sure that I could capture a failing test before getting it working again.
I managed to capture the failing scenario with a test but when I implemented the fix and tried to run
ember fastboot:test
it didn't actually pick up any of my changes. I then ran the dummy app with ember-cli-fastboot and it seemed to have fixed my issue when doing manual testing.At this point I thought it was a cache issue so I cleared my
dist
andtmp
folders and ranember fastboot:test
again and it still didn't work. Even a fresh build on Travis wasn't working correctly.I then published the addon as a patch version because I was relatively sure the fix was valid because of my manual testing and then when running the local
ember fastboot:test
again it started working.My best guess for a mental model of what is going on here is that the
ember fastboot:test
is somehow installing my addon from npm instead of using the local files, which would mean that it would need an npm publish before it would pick up changes that would fix any tests that are broken.I could probably recreate this issue if you would like a demo, but I'm wondering if this is a known behaviour already before I spend the time on attempting a re-creation.
Let me know if you have any questions 👍
The text was updated successfully, but these errors were encountered: