Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KCP config changes don't trigger rollout of control plane #83

Open
lukebond opened this issue Dec 14, 2023 · 2 comments
Open

KCP config changes don't trigger rollout of control plane #83

lukebond opened this issue Dec 14, 2023 · 2 comments

Comments

@lukebond
Copy link
Contributor

This is because this check is unimplemented: https://github.com/cluster-api-provider-k3s/cluster-api-k3s/blob/main/pkg/machinefilters/machine_filters.go#L254
@lukebond lukebond mentioned this issue Dec 14, 2023
Open
@lukebond
Copy link
Contributor Author

we should be able to port over controlplane/kubeadm/internal/filters_test.go from kubeadm and then work make them green, dropping the ones that aren't relevant to this provider.

@wikoion wikoion mentioned this issue May 14, 2024
Merged
@wikoion
Copy link
Contributor

wikoion commented May 20, 2024

This can be closed now @lukebond, fixed by #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukebond @wikoion