feat: Add get_applicable_variants as expt endpoint #210
Conversation
ayushjain17
force-pushed
the
applicableVariants
branch
from
4bea480
to
5cae429
Compare
Datron
force-pushed
the
main
branch
11 times, most recently
from
02832c3
to
a9afdb9
Compare
| Ok(HttpResponse::Ok().json(variants)) | ||
| } | ||
|
|
||
| fn decide_variant( |
There was a problem hiding this comment.
move to helper.rs
ayushjain17
force-pushed
the
applicableVariants
branch
from
5cae429
to
99c74ff
Compare
ayushjain17
force-pushed
the
applicableVariants
branch
from
99c74ff
to
d0acdb5
Compare
| if is_empty { | ||
| Some(exp.clone()) | ||
| } else { | ||
| match jsonlogic::partial_apply( |
There was a problem hiding this comment.
why partial apply ?
| } | ||
| } | ||
|
|
||
| impl FromRequest for ApplicableVariantsQuery { |
There was a problem hiding this comment.
Ideally we should not use fromrequest for individual types , as actix_web already has fromrequest implementation
for all http request data type
There was a problem hiding this comment.
We can use try_from in the handler , and expect query param as HashMap<String,String>
There was a problem hiding this comment.
doing it manually, it becomes quite flaky and something which is like the dev has to separately ensure the safety of the type and not the system
There was a problem hiding this comment.
But then everyone will add from_request impl for all the types
| None | ||
| } | ||
| }) | ||
| .ok_or_else(|| { |
There was a problem hiding this comment.
shouldn't toss be optional and default should be -1 ?
There was a problem hiding this comment.
get_applicable_variant is based on toss itself, toss is mandatory here
ayushjain17
force-pushed
the
applicableVariants
branch
2 times, most recently
from
59afb0a
to
8ff9c81
Compare
ayushjain17
force-pushed
the
applicableVariants
branch
from
8ff9c81
to
d86191c
Compare
Problem
get_applicable_variants only exist as a functionality inside client
Solution
Add get_applicable_variants as an endpoint in experimentation
API changes
Vec<Variants>Possible Issues in the future
Code duplication