Missing events from gateway client

[allstrive]

Description

There are two parts of the issue

• The gateway client in Jupyter Server doesn't generate a success event after getting a success response from gateway
• The gateway client in Jupyter Server does produce events on error condition, however, there's a possibility of missed error events

Reproduce

1. Launch a Jupyter Notebook with Enterprise Gateway
2. Once the notebook kernel is ready for use, expect an event log detailing success
3. No such log was found

We traced the code and validated various success /failure condition. We found that , code doesn't produce any gateway success event, the calling component does produce a kernel success event. There's no code to perform event generation from Gateway client that would allow a gateway event to be generated

Expected behavior

Gateway Client should generate both gateway success and failure event on every call to Enterprise Gateway

Context

• Operating System and version: Linux Ubuntu
• Browser and version: N/A
• Jupyter Server version: 2.6.0

Troubleshoot Output

We created a jupyter-server extension that would log a statement

Sending event <event Name> to <...>

When we ran the Jupyter Server we could see is

Sending event kernel_start to ...
Sending event kernel_restart to ...

We were expecting it to print

Sending event gateway_success to ...
Sending event gateway_error to ...

All we could see is gateway_error log on certain error conditions but no gateway_success. Looking at code , we could conclude that if code raised exceptions other than

• HTTPClientError
• ConnectionError
• gaierror
  It won't log the error event as well.

Command Line Output

N/A

Browser Output

N/A

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[Zsailer]

Solved by: #1288