-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
about Registry::Add some question #671
Comments
gjasny
added a commit
that referenced
this issue
Dec 18, 2023
Hello, you're right. In former times we had a third merge strategy. When it got removed, we did not optimize the code. Thanks, |
gjasny
added a commit
that referenced
this issue
Dec 19, 2023
gjasny
added a commit
that referenced
this issue
Dec 19, 2023
o( ̄▽ ̄)ブ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that inside the function
template <typename T> Family<T>& Registry::Add(const std::string& name , const std::string& help ,const Labels& labels)
, the "same_name_and_labels" is returned using 'name' and 'labels' as keys.However, later in the function, there is another duplication check using 'name' only as the key:
I am considering whether the latter check can be removed to make the key of Family consist of both 'name' and 'labels'. Could this adjustment help better optimize the function?
The text was updated successfully, but these errors were encountered: