Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the config files #245

Open
7 tasks
jukibom opened this issue Dec 5, 2023 · 0 comments
Open
7 tasks

Rework the config files #245

jukibom opened this issue Dec 5, 2023 · 0 comments
Labels
chunky boi It might sound simple but it's a deceptively large piece of work refactoring general code maintenance

Comments

@jukibom
Copy link
Owner

jukibom commented Dec 5, 2023

I am going to ABSOLUTELY HATE myself doing this but it needs to happen, and it needs a migration path from [braindead stupid land] to [glorious sensible town].

  • Change prefs to struct system rather than string lookup which is most likely a bit of a CPU slap given how often they're used now
  • Move graphics prefs into their own json file, excluded from steam cloud
  • Move regular prefs to their own file, included in steam cloud
  • Move input prefs to a folder, build out a simple profile system to allow for multiple. Store as sane human-readable json.
  • Do a detection step on first run - check for instances of old prefs and if new prefs do not exist, execute a migration script (with and a tooltip popup or something). Do not delete the file on completion so old versions will continue to work.
  • Celebrate the completion of this gargantuan refactor safe in the knowledge that all of the painful regressions and migration bullshit will achieve effectively nothing except people won't have to look at escaped freaking json when debugging the worst part of unity (input).
  • Consider life choices
@jukibom jukibom added chunky boi It might sound simple but it's a deceptively large piece of work refactoring general code maintenance labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chunky boi It might sound simple but it's a deceptively large piece of work refactoring general code maintenance
Projects
Development

No branches or pull requests

1 participant