Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default directory structure of decencies might not match with code #16

Open
huijbers opened this issue Mar 24, 2021 · 1 comment
Open
Labels
bug Something isn't working

Comments

@huijbers
Copy link

huijbers commented Mar 24, 2021

After installation, the default directory name of bids-matlab -a decency- is incorrect (when downloaded from git): bids-matlab =/= bids-matlab-master

When running the pipeline Error: bids-matlab cannot be found on your MATLABPATH

Quick fix: rename directory (or include in install instructions)
Proper fix: detect path to bids-matlab) and use dynamic path?

@jsheunis jsheunis added the bug Something isn't working label Mar 25, 2021
@jsheunis
Copy link
Owner

Thanks for logging this @huijbers! The "proper fix" could probably be the short term approach.

This is where the dependencies are checked, and it can be extended to search for variations on the base names of the dependent repositories. E.g. code can be added to check if bids-matlab or bids-matlab-master or bids-matlab-main is on the MATLAB.

A longer term option (as mentioned by @Remi-Gau) could be to consider using git submodules. I get the general idea but I haven't started looking into this further. If anyone wants to jump in, please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants