Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button background not showing #2

Open
wbaaron opened this issue Sep 21, 2012 · 1 comment
Open

Button background not showing #2

wbaaron opened this issue Sep 21, 2012 · 1 comment

Comments

@wbaaron
Copy link

wbaaron commented Sep 21, 2012

On Magento 1.5.1, the background for buttons doesn't appear correctly. The issue is because the button html is setup as

<button><span>Button Text</span></button>

instead of

<button><span><span>Button Text</span></span></button>

I've fixed this issue by updating lines 524-532 of boxes.css to

button { overflow:visible; width:auto; border:0; padding:0 4px 0 0; margin:0 8px 0 2px; background:transparent url(images/bkg_btn.png) 100% 0 no-repeat; cursor:pointer; }
button span { float:left; height:28px; background:transparent url(images/bkg_btn.png) 0 0 no-repeat; padding:0 0 0 8px; font:bold 12px/27px Tahoma, Verdana, Arial, sans-serif; text-align:center; white-space:nowrap; color:#f15a24; position:relative; right:4px; }

button:not(.disabled):hover { background-position:100% -70px; }
button:not(.disabled):hover > span { background-position:0 -70px; }
button:not(.disabled):active { position:relative; bottom:-1px; right:-1px; }

I haven't tested it too thoroughly. I haven't seen any problems yet though, so I think it should be good.

@jreinke
Copy link
Owner

jreinke commented Oct 25, 2012

Thanks for bug and fix report.
Could you make a PR for this?

calinsargan added a commit to calinsargan/magento-admin-theme that referenced this issue Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants