Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug : "Failed to parse time string" if the date string contains Chinese language character #315

Open
joomlagate opened this issue Mar 19, 2017 · 0 comments

Comments

@joomlagate
Copy link

Steps to reproduce the issue

in any Joomla language file (ini format) , write some Chinese language character in the date string after the comment symbol like:

; @date 三 2013

Expected result

com_localise will ignore anything it can not parse in "comments" and go on to open that language file for editing.

Actual result

com_localise refuse to open that language file and return a warning message:

0 DateTime::__construct(): Failed to parse time string (三 2013) at position 0 (�): Unexpected character

System information (as much as possible)

Joomla v3.6.5
com_localise v4.0.29 dev
PHP 7.0

Additional comments

I think, "comment" is comment, it is not CODE. Why com_localise will treat comment contents as normal code? If com_localise can not understand the Chinese language in date string ( which in fact is in comment line), just skip it, and go on to open that file. Because, we use com_localise to check real language keys , not comments.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant