Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for installation via Gemfile. #354

Open
lolgear opened this issue Sep 20, 2017 · 15 comments
Open

Support for installation via Gemfile. #354

lolgear opened this issue Sep 20, 2017 · 15 comments
Milestone

Comments

@lolgear
Copy link

lolgear commented Sep 20, 2017

So, it would be nice if theme could be installed by Gemfile

gem 'jekyll-theme-pixyll' 
@ashawley
Copy link
Collaborator

I worked on this in #334. Please add your 👍 to #333.

@lolgear
Copy link
Author

lolgear commented Sep 21, 2017

@ashawley done!
Do you need any help to support gems?

@ashawley
Copy link
Collaborator

Yeah, my gem patch needs people to review it. If you are familiar with gems and would want to give it a spin, that would be helpful. http://guides.rubygems.org/make-your-own-gem/

@johno
Copy link
Owner

johno commented Sep 21, 2017

Thanks for the hard work on this @ashawley 💟 ! Hoping to have time in the next week or so to review and publish to rubygems.

@ashawley
Copy link
Collaborator

I am going to go through the jekyll Quick start and enable pixyll as the theme and see if there are issues.

Building a gem means the theme needs to run on a variety of versions of ruby, jekyll, and so on. This is a lot different than using the theme as a repo with pinned dependencies. Might an automated test suite that runs in a variety environments be useful to keep track of whether the gem is working or not? I'm going to propose a Travis config be added in a sepearate PR. Might this conflict with downstream git fork users?

@ashawley
Copy link
Collaborator

ashawley commented Nov 3, 2017

I found other issues, but @johnotander quickly accepted my PR containing an initial Travis build.
I'll be able to grow the Travis build for the gem branch.

@claudiuconstantin
Copy link

Any news here?

@ashawley
Copy link
Collaborator

I need to further study a few more issues. See my last comment in #334.

@ashawley
Copy link
Collaborator

ashawley commented Dec 11, 2018

I'm picking this up again. I was about to close this issue as a duplicate of #333, but wanted to leave it open to discuss one aspect. Should we call the gem/theme pixyll or is there a convention that it should be jekyll-theme-pixyll?:

gem 'jekyll-theme-pixyll' 

I had planning to name it "pixyll", but am happy to open the bikeshedding to everyone. Please comment, but also vote:

@ashawley
Copy link
Collaborator

Motion to name the theme: jekyll-theme-pixyll

@ashawley
Copy link
Collaborator

Motion to name the theme: pixyll

@plttn
Copy link
Collaborator

plttn commented Dec 11, 2018

I'd lean towards jekyll-theme-pixyll simply because it seems to be convention on rubygems.

@claudiuconstantin
Copy link

claudiuconstantin commented Dec 11, 2018

What about pixyll-jekyll?

@ashawley
Copy link
Collaborator

I agree. The jekyll-theme-* prefix does seem to be a convention but there are exceptions, including minima.

@johno
Copy link
Owner

johno commented Dec 13, 2018

My 2c is that if pixyll is available we should use it! But I'll defer to @ashawley and @plttn.

@ashawley ashawley added this to the 3.0 milestone Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants