-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for installation via Gemfile. #354
Comments
@ashawley done! |
Yeah, my gem patch needs people to review it. If you are familiar with gems and would want to give it a spin, that would be helpful. http://guides.rubygems.org/make-your-own-gem/ |
Thanks for the hard work on this @ashawley 💟 ! Hoping to have time in the next week or so to review and publish to rubygems. |
I am going to go through the jekyll Quick start and enable pixyll as the theme and see if there are issues. Building a gem means the theme needs to run on a variety of versions of ruby, jekyll, and so on. This is a lot different than using the theme as a repo with pinned dependencies. Might an automated test suite that runs in a variety environments be useful to keep track of whether the gem is working or not? I'm going to propose a Travis config be added in a sepearate PR. Might this conflict with downstream git fork users? |
I found other issues, but @johnotander quickly accepted my PR containing an initial Travis build. |
Any news here? |
I need to further study a few more issues. See my last comment in #334. |
I'm picking this up again. I was about to close this issue as a duplicate of #333, but wanted to leave it open to discuss one aspect. Should we call the gem/theme
I had planning to name it "pixyll", but am happy to open the bikeshedding to everyone. Please comment, but also vote: |
Motion to name the theme:
|
Motion to name the theme:
|
I'd lean towards |
What about |
I agree. The |
So, it would be nice if theme could be installed by Gemfile
The text was updated successfully, but these errors were encountered: