Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

responseTimeout timer is not cleared on request error #39

Open
antishok opened this issue Dec 24, 2018 · 0 comments
Open

responseTimeout timer is not cleared on request error #39

antishok opened this issue Dec 24, 2018 · 0 comments

Comments

@antishok
Copy link

antishok commented Dec 24, 2018 •
edited
Loading

If you set a responseTimeout on a request, and then, before the responseTimeout has elapsed, the request has an error (e.g. connection timeout), then the responseTimeout timer is not cleared.
This can cause issues like a hanging process, or memory leaks.

I believe it just needs adding a clearTimeout in the req.on("error") handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antishok