New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIGINTEGER_LENGTH not needed #15

Open

fulldecent opened this issue Aug 4, 2019 · 2 comments

Contributor

fulldecent commented Aug 4, 2019

It should not be necessary to set a fixed length. I believe this is left over from the Solidity version of the ATS standard.

fulldecent mentioned this issue

Review necessity of fixed size BigNumber fulldecent/aion-aip040#6

Closed

Owner

jennijuju commented Aug 6, 2019

AionBuffer.put32 is for BigInteger that has a size of 32 bytes.
32 bytes is used for easier decoding for events.

Contributor Author

fulldecent commented Aug 6, 2019

Could you please explain more and provide references? In AIP-041 we only have BigIntegers everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment