Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seasons): Add links back to a series and season from an episode. #1823

Closed
wants to merge 10 commits into from
Closed

feat(seasons): Add links back to a series and season from an episode. #1823

wants to merge 10 commits into from

Conversation

BrianCArnold
Copy link
Contributor

This fixes #1822.

It also parallelizes getting seasons from the server, instead of having to wait for each list of episodes in a season to load before starting to load the next season's list of episodes.

@jellyfin-bot jellyfin-bot added the vue Pull requests that edit or add Vue files label Nov 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ferferga ferferga added the blocked Something depends on another issue or Pull Request label Dec 27, 2022
@BrianCArnold
feat(seasons): Add links back to a series and season from an episode.
30b5fc5
@BrianCArnold
feat(seasons): Fixed some code smells.
877f076
@BrianCArnold
feat(playlist): Temporary use of CollectionTabs for playlist for test…
c87fd69 
…ing.

Need to create new component for playlist
 * Need to display in list
 * Need to be able to drag/reorder
@BrianCArnold
feat(playlist): Got playlists working for the most part. (the skeleto…
666a257 
…n display isn't quite right, though.)
@BrianCArnold
feat(playlist): Remove showing of "loading" skel during moving items.
f980842
@BrianCArnold
feat(playlist): Removed code smells.
f2f04d1
@BrianCArnold
feat(playlist): Fixed some linting issues.
d78bbdd
@BrianCArnold
feat(playlist): Caused an issue while trying to clean things up. Fixe…
cd06fa7 
…d now.
@BrianCArnold
feat(playlist): Got saving play queue to playlist working. :-)
db0c37f
@BrianCArnold
feat(playlist): Fixed lint issues.
ad15b43
@jellyfin-bot jellyfin-bot added the frontend:store Pull requests or issues that deal with stores label Feb 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 2679da4
Status ✅ Deployed!
Preview URL https://3c57130f.jf-vue.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@ThibaultNocchi
Copy link
Member

Hey @BrianCArnold, sorry for taking this long to answer.

We're currently migrating to Vue 3 in the vite branch, could you apply your fix in there please?

Thanks!

@jellyfin-bot jellyfin-bot added the merge conflict Something has merge conflicts label Apr 3, 2023
@ferferga ferferga removed the blocked Something depends on another issue or Pull Request label Apr 3, 2023
@ferferga
Copy link
Member

ferferga commented Apr 3, 2023

@BrianCArnold Hey, vite has been merged now and the client is fully on Vue 3. I'm removing the blocked label.
Can you please rebase this so we can apply it?

@BrianCArnold
Copy link
Contributor Author

Absolutely, I'll work on that in the next couple days (if I managed to remember, ADHD is a pain)

@ferferga ferferga force-pushed the master branch 3 times, most recently from 5e698fd to 26d3ab7 Compare May 1, 2023 22:03
@ferferga ferferga force-pushed the master branch 2 times, most recently from bc856ac to 7336bfd Compare August 16, 2023 19:17
@BrianCArnold
Copy link
Contributor Author

Hey, guess who just remembered this exists? Gonna work on it now.

@BrianCArnold
Copy link
Contributor Author

BrianCArnold commented Nov 7, 2023 •
edited
Loading

Superseded by #2135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
frontend:store Pull requests or issues that deal with stores merge conflict Something has merge conflicts vue Pull requests that edit or add Vue files
Projects
Ongoing development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No link back to a series or season from an episode.
4 participants
@BrianCArnold @jellyfin-bot @ThibaultNocchi @ferferga